Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jekyll should be using Gem bins, not system. #6498

Closed
envygeeks opened this issue Oct 29, 2017 · 5 comments
Closed

Jekyll should be using Gem bins, not system. #6498

envygeeks opened this issue Oct 29, 2017 · 5 comments
Assignees
Labels
frozen-due-to-age has-pull-request Somebody suggested a solution to fix this issue

Comments

@envygeeks
Copy link
Contributor

The system can wrap in on itself. Jekyll should be using Ruby to find Ruby stuff.

@ashmaroli
Copy link
Member

Please elaborate..

@envygeeks
Copy link
Contributor Author

Use Gem. It will tell you where it's binary is. Instead of randomly running an exec assuming that the bundler you are looking for is the right bundler.

@DirtyF
Copy link
Member

DirtyF commented Oct 29, 2017

What problem are we trying to resolve here?

@ashmaroli
Copy link
Member

I think Jordon's referring to the utility function in

def bundle_install(path)
Jekyll.logger.info "Running bundle install in #{path.cyan}..."
Dir.chdir(path) do
process, output = Jekyll::Utils::Exec.run("bundle", "install")
output.to_s.each_line do |line|
Jekyll.logger.info("Bundler:".green, line.strip) unless line.to_s.empty?
end
raise SystemExit unless process.success?
end
end

@envygeeks
Copy link
Contributor Author

I've already shipped a pull-request through my bot.

@DirtyF DirtyF added the has-pull-request Somebody suggested a solution to fix this issue label Oct 29, 2017
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age has-pull-request Somebody suggested a solution to fix this issue
Projects
None yet
Development

No branches or pull requests

4 participants