Add jekyll-commonmark as an available converter in core

[pathawks]

• I read the CONTRIBUTION file at https://jekyllrb.com/docs/contributing/
• This is a feature request.

Should we add jekyll-commonmark to core?

We could start by adding a stub MarkDown converter to lib/jekyll/converters/markdown/ like we have for rdiscount and redcarpet?

/cc: @jekyll/core @jekyll/plugin-core

[ashmaroli]

Should we add jekyll-commonmark to core?

Maybe start testing on Windows before that..?

[pathawks]

@ashmaroli Could you set that up for jekyll/jekyll-commonmark? That would be awesome 😍:tada:

[ashmaroli]

Could you set that up for jekyll/jekyll-commonmark? That would be awesome

Sure.. TODO for tomorrow 😃

[pathawks]

jekyll/jekyll-commonmark#11

[ashmaroli]

Required:

• Plugin Test-suite
• Compatibility with Linux, OSX, Windows

[pathawks]

[ashmaroli]

CI is only running RuboCop actually.. there are no RSpec files to be run..

[pathawks]

Oh! 😅

[pathawks]

Specs have been added.
https://github.com/jekyll/jekyll-commonmark/blob/185f6fd49fde8d5f183cf584a469e6fff50473c7/spec/jekyll_commonmark_spec.rb

[parkr]

@pathawks Excellent! Want to submit a PR to make this first-class in Jekyll? E.g. markdown: cmark or whatever it’s now called would activate this plugin.

One thing to consider as well is a markdown: GFM which adds some github extensions to this plugin as settings to make it as close to the markdown experience on GitHub as possible. That can come later though.

[DirtyF]

Related:

• https://github.com/github/jekyll-commonmark-ghpages
• https://github.com/github/cmark

[pathawks]

@DirtyF Yes, I have been monitoring that as well.

If Github is doing this on their own, maybe we should just use their implementation instead?

[ashmaroli]

@pathawks What's the status on this..?

[parkr]

I'd really love to merge the jekyll-commonmark-ghpages code upstream and just use jekyll-commonmark!