New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rdoc to 6.0 #6600
Bump rdoc to 6.0 #6600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: |
Gemfile
Outdated
@@ -75,7 +75,7 @@ group :jekyll_optional_dependencies do | |||
gem "jekyll-redirect-from" | |||
gem "kramdown", "~> 1.14" | |||
gem "mime-types", "~> 3.0" | |||
gem "rdoc", "~> 5.0" | |||
gem "rdoc", "~> 6.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe still allow 5.x
for Ruby 2.1?
gem "rdoc", [">= 5.0", "< 7.0"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like we have for other gems in similar situations.
gem "rdoc", RUBY_VERSION >= "2.2.2" ? "~> 6.0" : "~> 5.1"
We've dropped Ruby 2.1, if that changes anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helps support Ruby 2.2.0 & 2.2.1, which we still theoretically support.
@jekyllbot: merge +dev |
Fix #6599