Fix pretty permalinks in server auto #691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
I feel like there are more tests I need to write. |
|
coverage looks good to me. the only thing I would do is to run it through a coverage tool and double check. |
|
+1 |
|
this will need to be updated when/if we merge #963 |
|
Do we care about this anymore? Seems like almost no one is interested in this functionality |
|
What is this and what does it have to do with server auto? |
|
I'm interested in it. My /blog currently hardcodes this feature, so index.html: < a href="/blog{{ post.url | remove:'.html' }}">{{ post.title }} |
| @@ -202,7 +204,7 @@ def render(layouts, site_payload) | |||
| def destination(dest) | |||
| # The url needs to be unescaped in order to preserve the correct filename | |||
| path = File.join(dest, CGI.unescape(self.url)) | |||
| path = File.join(path, "index.html") if template[/\.html$/].nil? | |||
| path = File.join(path, "index.html") if template[/\.html$/].nil? && self.site.permalink_style != :pretty_flat | |||
There was a problem hiding this comment.
Maybe the condition could be unless template.end_with?(".html") || self.site.permalink_style == :pretty_flat, is more readable this way to me
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of #219 for posts, not just pages.