Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure cache_dir #7232

Merged
merged 1 commit into from Feb 15, 2019
Merged

Configure cache_dir #7232

merged 1 commit into from Feb 15, 2019

Conversation

ashmaroli
Copy link
Member

@ashmaroli ashmaroli commented Sep 9, 2018 •
edited

Resolves #7220

Additionally, this ensures that the cache is always "within the source_dir" and also sanitizes the cache_dir configuration..

@ashmaroli ashmaroli force-pushed the cache-config branch 2 times, most recently from 2704e0d to 4681ca8 Compare September 9, 2018 14:29
@DirtyF DirtyF requested a review from a team October 28, 2018 05:42
@DirtyF DirtyF requested a review from a team October 28, 2018 05:46
@DirtyF DirtyF added this to the 4.0 milestone Oct 28, 2018
@DirtyF DirtyF added this to Reviewable in Jekyll 4.1 Jan 27, 2019
@ashmaroli
Copy link
Member Author

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 06c49c7 into jekyll:master Feb 15, 2019
jekyllbot added a commit that referenced this pull request Feb 15, 2019
@jekyllbot
Update history to reflect merge of #7232 [ci skip]
55f0980
@ashmaroli ashmaroli deleted the cache-config branch February 15, 2019 13:47
@mattr- mattr- moved this from Reviewable to Done in Jekyll 4.1 Feb 16, 2019
@Convincible
Copy link

Why was it important that the cache directory be in the source directory? I want to store my cache somewhere else entirely!

@ashmaroli
Copy link
Member Author

Why was it important that the cache directory be in the source directory?

  • Partially influenced by Make site.source the cynosure of a Jekyll Site #6578
  • Since, this is a very new feature, I felt limiting its flexibility will allow loosening as required.
  • If not at source_dir, the other location would be at $PWD which (in my head) appeared to be brittle implementation of the "disk-cache". My $PWD could be anywhere and Jekyll would build the site properly as long as I provided proper values to the --source CLI switch. So, there was a chance that (all those) location(s) would be littered with .jekyll-cache directories in turn reducing its effectiveness.

@ashmaroli ashmaroli mentioned this pull request Aug 27, 2019
Closed
@jekyll jekyll locked and limited conversation to collaborators Aug 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

@pathawks pathawks Awaiting requested review from pathawks

Assignees
No one assigned
Labels
enhancement frozen-due-to-age
Projects
No open projects
Jekyll 4.1
  
Done
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Custom cache_dir configuration not honored
4 participants
@ashmaroli @Convincible @DirtyF @jekyllbot