New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: gem-based themes inheritance #7344
Comments
This is a concept that I have thought about before, and even something that I thought might already be possible. I'd be interested to discuss this more, especially since this not only brings some exciting features to Jekyll but some possible headaches as well (cue the WordPress child theme flashbacks). This is issue thread the best place to discuss? I'd hate to spam people on a topic that could get really long |
@daviddarnes Go ahead and list down all that you have to say regarding this feature.. |
Alrighty, I'll just list up the positive and possible negative implications of this: Positive
Negative
I've numbered these so they can be easily referenced. I'll be honest, those negatives are more me being devils advocate to myself. I've put them incase people have similar thoughts or are able to justify them better than I can |
@daviddarnes Thanks for laying things out, it's best if we think things through together 👍 Here's how I envision this feature:
|
@DirtyF it just dawned on me why I thought this was possible, because I thought you could already import a theme gem just like a Jekyll gem plugin anyway. This is the convention we're talking about yes? What currently prevents us importing a theme into another theme as a gem? |
I just tried it. I overode minima and publish the theme gem: https://rubygems.org/gems/jekyll-theme-minima Now when I create a new jekyll site and specify the child theme, it won't build: Trace
|
I guess this is what needs to be fixed in order for it to work. Do we need to establish behaviour of child/parent themes too? |
Any more progress on this topic? Clearly not a huge demand, but certainly had potential |
No, Jekyll core team is very limited at the moment. Any help is warmly welcome if someone is interested in contributing. |
@issuehuntfest has funded $60.00 to this issue. See it on IssueHunt |
@0maxxam0 has funded $2.00 to this issue.
|
Summary
Support for parent/child themes allowing users to build upon existing themes.
See benbalter/jekyll-remote-theme#35 (comment)
Motivation
Guide-level explanation
Reference-level explanation
theme/_config.yml
?)_config.yml
/cc @jekyll/themes @jekyll/minima, @mmistakes, @daviddarnes, @nickgarlis
The text was updated successfully, but these errors were encountered: