Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace `` with html tag #7879

Merged
merged 3 commits into from Oct 29, 2019
Merged

Replace `` with html tag #7879

merged 3 commits into from Oct 29, 2019

Conversation

JinsYin
Copy link
Contributor

@JinsYin JinsYin commented Oct 28, 2019

@mattr-
Copy link
Member

mattr- commented Oct 28, 2019

The motivation behind this change isn't clear. Can you please explain why it was necessary to make this change and what the benefit of this is?

DirtyF
DirtyF requested changes Oct 28, 2019
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to our preview an HTML tag is not properly closed.

docs/_data/jekyll_variables.yml Outdated Show resolved Hide resolved
DirtyF
DirtyF approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@DirtyF
Copy link
Member

DirtyF commented Oct 29, 2019

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit aee034f into jekyll:master Oct 29, 2019
jekyllbot added a commit that referenced this pull request Oct 29, 2019
@jekyllbot
Update history to reflect merge of #7879 [ci skip]
b0e15a5
@jekyll jekyll locked and limited conversation to collaborators Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
documentation frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JinsYin @mattr- @DirtyF @jekyllbot