Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The tests in test_convertible.rb trying to match the file paths in the output will fail if path contains special characters #8137

Closed
dleidert opened this issue Apr 25, 2020 · 0 comments · Fixed by #8138
Closed

The tests in test_convertible.rb trying to match the file paths in the output will fail if path contains special characters #8137

dleidert opened this issue Apr 25, 2020 · 0 comments · Fixed by #8138
Labels
frozen-due-to-age has-pull-request Somebody suggested a solution to fix this issue

Comments

@dleidert
Copy link
Contributor

Hi there,

I'm part of the team which packages jekyll for Debian. In our case the path where the source is contains a + sign. So assert_match(%r!#{File.join(@base, name)}!, out) in test/test_new_command.rb fails. because the plus sign is not escaped. The solution is using Regexp.escape() as shown in this patch:

https://salsa.debian.org/ruby-team/jekyll/-/blob/master/debian/patches/0022-escape-regex-characters-in-match.patch
@dleidert dleidert mentioned this issue Apr 25, 2020
Merged
@jekyllbot jekyllbot added the has-pull-request Somebody suggested a solution to fix this issue label Apr 25, 2020
@jekyll jekyll locked and limited conversation to collaborators Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
frozen-due-to-age has-pull-request Somebody suggested a solution to fix this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Escape regex characters in paths to match
2 participants
@jekyllbot @dleidert