-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Can jekyll-sass-converter be made an optional installation? (sassc install is slow) #8184
Comments
Unfortunately, we cannot remove a hard dependency. Our next release will be v4.1.0 (minor-version bump) and removing a hard dependency in a minor version bump is against the principles of semver (Semantic Versioning). Sorry, you'll have to depend on Netlify's caching (albeit apparent lack of one for preview-deploys). |
I hope you all see this as the absolute disaster that it is for Jekyll. Slow builds are a huge reason for jumping ship re: https://hacks.mozilla.org/2020/10/to-eleventy-and-beyond/ |
to add to this, there's an issue open in sassc about providing a binary
gem:
sass/sassc-ruby#189
for our projects we've set up a gem repository hosting our own binary
gems using gem-compiler, for alpine/musl, which lead to finding some
quirks on how rubygems finds platform specific gems for linux+glibc:
rubygems/rubygems#3174
i tried building binary gems for glibc but since we're using rbenv for
development, libraries end up hardcoding local directories and i haven't
had time to fix it.
maybe a first step would be helping sassc to provide a binary gem
officially, that would reduce build times for everyone :)
|
@Robbie-Cook The build time referred to in the Mozilla blog post is the time Jekyll took during multiple build sessions (i.e., from running |
Is this still not an option? We don't use sass in our project but still have to wait an extra 3 minutes on each Netlify build to include sassc, despite not needing it. |
Thanks for your work on Jekyll!
Currently,
jekyll-sass-converter
is installed by default (hard dependency), and it bringssassc
as a dependency. The installation ofsassc
can be very slow (ex here more than 3 minutes on a given Netlify build.Although the real fix would be to accelerate
sassc
installation (sass/sassc-ruby#189), it will take time and effort.Therefore I wonder if it could be done to make
jekyll-sass-converter
a soft requirement?Thanks for taking this input into consideration ^_^
The text was updated successfully, but these errors were encountered: