Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Can jekyll-sass-converter be made an optional installation? (sassc install is slow) #8184

Closed
thbar opened this issue May 17, 2020 · 5 comments

Comments

@thbar
Copy link

thbar commented May 17, 2020

Thanks for your work on Jekyll!

Currently, jekyll-sass-converter is installed by default (hard dependency), and it brings sassc as a dependency. The installation of sassc can be very slow (ex here more than 3 minutes on a given Netlify build.

Although the real fix would be to accelerate sassc installation (sass/sassc-ruby#189), it will take time and effort.

Therefore I wonder if it could be done to make jekyll-sass-converter a soft requirement?

Thanks for taking this input into consideration ^_^

@ashmaroli
Copy link
Member

Unfortunately, we cannot remove a hard dependency. Our next release will be v4.1.0 (minor-version bump) and removing a hard dependency in a minor version bump is against the principles of semver (Semantic Versioning).

Sorry, you'll have to depend on Netlify's caching (albeit apparent lack of one for preview-deploys).

@Robbie-Cook
Copy link

I hope you all see this as the absolute disaster that it is for Jekyll. Slow builds are a huge reason for jumping ship re: https://hacks.mozilla.org/2020/10/to-eleventy-and-beyond/

@fauno
Copy link
Member

fauno commented Jan 22, 2021 via email

@ashmaroli
Copy link
Member

@Robbie-Cook The build time referred to in the Mozilla blog post is the time Jekyll took during multiple build sessions (i.e., from running jekyll build or jekyll serve both of which comprises of reading the source files, converting and finally writing the HTML files to disk.)
That time has nothing to do with sassc gem or jekyll-sass-converter installation.
Gems are ideally installed once in a while, and not for every build session.

@typhoon2099
Copy link

Is this still not an option? We don't use sass in our project but still have to wait an extra 3 minutes on each Netlify build to include sassc, despite not needing it.

@jekyll jekyll locked and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants