Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: The Jekyll Docs site is broken and always displays "Deployment" as the page heading. #9527

Open
michaelnordmeyer opened this issue Jan 14, 2024 · 3 comments
Labels
documentation has-pull-request Somebody suggested a solution to fix this issue

Comments

@michaelnordmeyer
Copy link
Contributor

Quickstart displays the content of its page, but has "Deployment" as headline.

Installation displays the content of its page, but has "Deployment" as headline.

The same goes for all other pages in section docs, except the step-by-step tutorial.

In the step-by-step tutorial "Deployment" becomes the second headline.

And the last menu item in the right docs sidebar called "Deployment" has broken styling.

@heironimus
Copy link

PR #9338 introduced this bug. Reverting the PR fixes it.

@velle
Copy link
Contributor

velle commented Feb 12, 2024

I think I found the problem. In docs_contents_mobile.html, page should be replaced with current_page.

The typo is only in the mobile version of the docs contents html, but the problem affects both mobile and regular output.

I don't like that its called current_page btw. To me it implies that its the page currently shown/active, which is what page holds. IMHO p, pg or menu_item_page would be better.

@heironimus
Copy link

I think I found the problem. In docs_contents_mobile.html, page should be replaced with current_page.

@velle Yep, that works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation has-pull-request Somebody suggested a solution to fix this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants