Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly slugify the title from wordpress.xml #565

Closed
wants to merge 2 commits into from
Closed

Correctly slugify the title from wordpress.xml #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73212a2
Turn the title into a slug
tombell May 27, 2012
988a7a8
Add test case for wordpressdotcom migrator
tombell May 31, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions jekyll.gemspec
View file
Open in desktop
Expand Up @@ -38,6 +38,7 @@ Gem::Specification.new do |s|
s.add_development_dependency('RedCloth', "~> 4.2")
s.add_development_dependency('rdiscount', "~> 1.6")
s.add_development_dependency('redcarpet', "~> 1.9")
s.add_development_dependency('hpricot', "~> 0.8.6")

# = MANIFEST =
s.files = %w[
Expand Down
4 changes: 3 additions & 1 deletion lib/jekyll/migrators/wordpressdotcom.rb
View file
Open in desktop
Expand Up @@ -19,7 +19,7 @@ def self.process(filename = "wordpress.xml")
permalink_title = item.at('wp:post_name').inner_text
# Fallback to "prettified" title if post_name is empty (can happen)
if permalink_title == ""
permalink_title = title.downcase.split.join('-')
permalink_title = title.gsub(/[^[:alnum:]]+/, '-').downcase
end

date = Time.parse(item.at('wp:post_date').inner_text)
Expand Down Expand Up @@ -65,6 +65,8 @@ def self.process(filename = "wordpress.xml")
import_count.each do |key, value|
puts "Imported #{value} #{key}s"
end

import_count
end
end
end
149 changes: 149 additions & 0 deletions test/fixtures/wordpress.xml
View file
Open in desktop
@@ -0,0 +1,149 @@
<?xml version="1.0" encoding="UTF-8" ?>
<!-- This is a WordPress eXtended RSS file generated by WordPress as an export of your site. -->
<!-- It contains information about your site's posts, pages, comments, categories, and other content. -->
<!-- You may use this file to transfer that content from one site to another. -->
<!-- This file is not intended to serve as a complete backup of your site. -->

<!-- To import this information into a WordPress site follow these steps: -->
<!-- 1. Log in to that site as an administrator. -->
<!-- 2. Go to Tools: Import in the WordPress admin panel. -->
<!-- 3. Install the "WordPress" importer from the list. -->
<!-- 4. Activate & Run Importer. -->
<!-- 5. Upload this file using the form provided on that page. -->
<!-- 6. You will first be asked to map the authors in this export file to users -->
<!-- on the site. For each author, you may choose to map to an -->
<!-- existing user on the site or to create a new user. -->
<!-- 7. WordPress will then import each of the posts, pages, comments, categories, etc. -->
<!-- contained in this file into your site. -->

<!-- generator="WordPress.com" created="2012-05-30 23:38"-->
<rss version="2.0"
xmlns:excerpt="http://wordpress.org/export/1.2/excerpt/"
xmlns:content="http://purl.org/rss/1.0/modules/content/"
xmlns:wfw="http://wellformedweb.org/CommentAPI/"
xmlns:dc="http://purl.org/dc/elements/1.1/"
xmlns:wp="http://wordpress.org/export/1.2/"
>

<channel>
<title>Test</title>
<link>http://tombtest.wordpress.com</link>
<description>A fine WordPress.com site</description>
<pubDate>Wed, 30 May 2012 23:38:48 +0000</pubDate>
<language>en</language>
<wp:wxr_version>1.2</wp:wxr_version>
<wp:base_site_url>http://wordpress.com/</wp:base_site_url>
<wp:base_blog_url>http://tombtest.wordpress.com</wp:base_blog_url>

<wp:author><wp:author_id>1402643</wp:author_id><wp:author_login>tombell</wp:author_login><wp:author_email>tomb@tomb.io</wp:author_email><wp:author_display_name><![CDATA[tombell]]></wp:author_display_name><wp:author_first_name><![CDATA[]]></wp:author_first_name><wp:author_last_name><![CDATA[]]></wp:author_last_name></wp:author>

<wp:category><wp:term_id>1</wp:term_id><wp:category_nicename>uncategorized</wp:category_nicename><wp:category_parent></wp:category_parent><wp:cat_name><![CDATA[Uncategorized]]></wp:cat_name></wp:category>

<generator>http://wordpress.com/</generator>
<cloud domain='tombtest.wordpress.com' port='80' path='/?rsscloud=notify' registerProcedure='' protocol='http-post' />
<image>
<url>http://s2.wp.com/i/buttonw-com.png</url>
<title>Test</title>
<link>http://tombtest.wordpress.com</link>
</image>
<atom:link rel="search" type="application/opensearchdescription+xml" href="http://tombtest.wordpress.com/osd.xml" title="Test" />
<atom:link rel='hub' href='http://tombtest.wordpress.com/?pushpress=hub'/>

<item>
<title>Hello world!</title>
<link>http://tombtest.wordpress.com/2012/05/30/hello-world/</link>
<pubDate>Wed, 30 May 2012 23:37:02 +0000</pubDate>
<dc:creator>tombell</dc:creator>
<guid isPermaLink="false">http://tombtest.wordpress.com/?p=1</guid>
<description></description>
<content:encoded><![CDATA[Welcome to <a href="https://wordpress.com/">WordPress.com</a>! This is your very first post. Click the Edit link to modify or delete it, or <a title="Direct link to Add New in the Admin Dashboard" href="/wp-admin/post-new.php">start a new post</a>. If you like, use this post to tell readers why you started this blog and what you plan to do with it.

Happy blogging!]]></content:encoded>
<excerpt:encoded><![CDATA[]]></excerpt:encoded>
<wp:post_id>1</wp:post_id>
<wp:post_date>2012-05-30 23:37:02</wp:post_date>
<wp:post_date_gmt>2012-05-30 23:37:02</wp:post_date_gmt>
<wp:comment_status>open</wp:comment_status>
<wp:ping_status>open</wp:ping_status>
<wp:post_name>hello-world</wp:post_name>
<wp:status>publish</wp:status>
<wp:post_parent>0</wp:post_parent>
<wp:menu_order>0</wp:menu_order>
<wp:post_type>post</wp:post_type>
<wp:post_password></wp:post_password>
<wp:is_sticky>0</wp:is_sticky>
<category domain="category" nicename="uncategorized"><![CDATA[Uncategorized]]></category>
<wp:comment>
<wp:comment_id>1</wp:comment_id>
<wp:comment_author><![CDATA[Mr WordPress]]></wp:comment_author>
<wp:comment_author_email></wp:comment_author_email>
<wp:comment_author_url>http://WordPress.com/</wp:comment_author_url>
<wp:comment_author_IP></wp:comment_author_IP>
<wp:comment_date>2012-05-30 23:37:02</wp:comment_date>
<wp:comment_date_gmt>2012-05-30 23:37:02</wp:comment_date_gmt>
<wp:comment_content><![CDATA[Hi, this is a comment.<br />To delete a comment, just log in, and view the posts' comments, there you will have the option to edit or delete them.]]></wp:comment_content>
<wp:comment_approved>1</wp:comment_approved>
<wp:comment_type></wp:comment_type>
<wp:comment_parent>0</wp:comment_parent>
<wp:comment_user_id>0</wp:comment_user_id>
</wp:comment>
</item>
<item>
<title>About</title>
<link>http://tombtest.wordpress.com/about/</link>
<pubDate>Wed, 30 May 2012 23:37:02 +0000</pubDate>
<dc:creator>tombell</dc:creator>
<guid isPermaLink="false">http://tombtest.wordpress.com/?page_id=2</guid>
<description></description>
<content:encoded><![CDATA[This is an example of a page. Unlike posts, which are displayed on your blog’s front page in the order they’re published, pages are better suited for more timeless content that you want to be easily accessible, like your About or Contact information. Click the Edit link to make changes to this page or <a title="Direct link to Add New in the Admin Dashboard" href="/wp-admin/post-new.php?post_type=page">add another page</a>.]]></content:encoded>
<excerpt:encoded><![CDATA[]]></excerpt:encoded>
<wp:post_id>2</wp:post_id>
<wp:post_date>2012-05-30 23:37:02</wp:post_date>
<wp:post_date_gmt>2012-05-30 23:37:02</wp:post_date_gmt>
<wp:comment_status>open</wp:comment_status>
<wp:ping_status>open</wp:ping_status>
<wp:post_name>about</wp:post_name>
<wp:status>publish</wp:status>
<wp:post_parent>0</wp:post_parent>
<wp:menu_order>0</wp:menu_order>
<wp:post_type>page</wp:post_type>
<wp:post_password></wp:post_password>
<wp:is_sticky>0</wp:is_sticky>
<wp:postmeta>
<wp:meta_key>_wp_page_template</wp:meta_key>
<wp:meta_value><![CDATA[default]]></wp:meta_value>
</wp:postmeta>
</item>
<item>
<title>Another/Post With Slash</title>
<link>http://tombtest.wordpress.com/2012/05/30/anotherpost-with-slash/</link>
<pubDate>Wed, 30 May 2012 23:37:47 +0000</pubDate>
<dc:creator>tombell</dc:creator>
<guid isPermaLink="false">http://tombtest.wordpress.com/?p=3</guid>
<description></description>
<content:encoded><![CDATA[This is some blog content]]></content:encoded>
<excerpt:encoded><![CDATA[]]></excerpt:encoded>
<wp:post_id>3</wp:post_id>
<wp:post_date>2012-05-30 23:37:47</wp:post_date>
<wp:post_date_gmt>2012-05-30 23:37:47</wp:post_date_gmt>
<wp:post_name></wp:post_name>
<wp:comment_status>open</wp:comment_status>
<wp:ping_status>open</wp:ping_status>
<wp:status>publish</wp:status>
<wp:post_parent>0</wp:post_parent>
<wp:menu_order>0</wp:menu_order>
<wp:post_type>post</wp:post_type>
<wp:post_password></wp:post_password>
<wp:is_sticky>0</wp:is_sticky>
<category domain="category" nicename="uncategorized"><![CDATA[Uncategorized]]></category>
<wp:postmeta>
<wp:meta_key>_edit_last</wp:meta_key>
<wp:meta_value><![CDATA[1402643]]></wp:meta_value>
</wp:postmeta>
<wp:postmeta>
<wp:meta_key>jabber_published</wp:meta_key>
<wp:meta_value><![CDATA[1338421069]]></wp:meta_value>
</wp:postmeta>
</item>
</channel>
</rss>
4 changes: 4 additions & 0 deletions test/helper.rb
View file
Open in desktop
Expand Up @@ -28,6 +28,10 @@ def source_dir(*subdirs)
File.join(File.dirname(__FILE__), 'source', *subdirs)
end

def fixtures_dir(*subdirs)
File.join(File.dirname(__FILE__), 'fixtures', *subdirs)
end

def clear_dest
FileUtils.rm_rf(dest_dir)
end
Expand Down
18 changes: 18 additions & 0 deletions test/migrators/test_wordpressdotcom.rb
View file
Open in desktop
@@ -0,0 +1,18 @@
require 'helper'
require 'jekyll/migrators/wordpressdotcom'

class TestWordpressDotCom < Test::Unit::TestCase
context 'migrating from wordpress.com' do
setup do
@wordpressxml = File.join(fixtures_dir, 'wordpress.xml')
end

should 'import post with a slash in the title from wordpress.xml' do
stub(FileUtils).mkdir_p(anything)
stub(File).open(anything, anything)
imported = Jekyll::WordpressDotCom.process(@wordpressxml)
assert_equal 1, imported['page']
assert_equal 2, imported['post']
end
end
end