Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Accessibility of Social Media Links #257

Open
austinseraphin opened this issue Jul 9, 2018 · 8 comments
Open

Improve Accessibility of Social Media Links #257

austinseraphin opened this issue Jul 9, 2018 · 8 comments
Assignees
Labels
has-pull-request A proposed change on merge will close this social-media-support

Comments

@austinseraphin
Copy link

The links to external sites such as Twitter require a text label. Currently the links have the local site's title instead of the external site's title. For example, the Twitter link should read "Twitter"

@pathawks
Copy link
Member

Maybe “username on social network” ?

@DirtyF
Copy link
Member

DirtyF commented Jul 10, 2018

Correct me if I'm wrong but title attribute isn't necessarily read by screenreaders: https://www.deque.com/blog/text-links-practices-screen-readers/

@jekyllbot

This comment has been minimized.

@jekyllbot jekyllbot added the stale label Nov 1, 2018
@DirtyF DirtyF added the has-pull-request A proposed change on merge will close this label Nov 2, 2018
@DirtyF
Copy link
Member

DirtyF commented Nov 2, 2018

@austinseraphin aria-label was added in #302

@jekyllbot jekyllbot removed the stale label Nov 2, 2018
@DirtyF DirtyF self-assigned this Jan 17, 2020
@mgifford
Copy link

What is the status of this?

@austinseraphin
Copy link
Author

As of version 2.5.1 the links still read as the user ID. They should say the name of the social network instead, i.e. Twitter.

@mgifford
Copy link

mgifford commented Mar 9, 2021

As @DirtyF suggested. Titles aren't good for this. This info should be in the alt attribute instead of title.

@austinseraphin
Copy link
Author

Yes. All meaningful images should have alt tags, and all placeholder images shouldn't Usually Minima does a good job with this. If the social media icons have the wrong alt text then that would cause the screen reader to misread them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-pull-request A proposed change on merge will close this social-media-support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants