Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting dark theme in _config.yml appears to be ignored #717

Closed
joshbuker opened this issue Mar 5, 2023 · 4 comments
Closed

Setting dark theme in _config.yml appears to be ignored #717

joshbuker opened this issue Mar 5, 2023 · 4 comments

Comments

@joshbuker
Copy link

Using minima, setting the theme to dark inside of _config.yml appears to be getting ignored:

minima:
  skin: dark

The other configuration appears to be getting pulled in correctly, so it's not an issue of _config.yml being ignored entirely. It's specifically the theme value that has no effect.

To replicate, see: https://github.com/joshbuker/gsd-tools/tree/2269b5ba3a054844eaaf19598a6870a6245f658b/website

The issue happens both when running locally and when deployed via Cloudflare pages.

@corite
Copy link

corite commented Mar 7, 2023

I have the same Issue, both with a local and a Github Pages deployment.

@ashmaroli
Copy link
Member

@joshbuker The "skins" are part of unreleased changes to the project. To use them, you will have to consume the theme via jekyll-remote-theme plugin.
(Caution: Some of the other changes included are not backwards-compatible. Use at your own risk.)

@joshbuker
Copy link
Author

Gotcha, the confusion stems from the project README containing changes that have yet to be released.

Similar issue to #709, where unreleased breaking changes on main instead of a development branch is causing some problems.

The answer to my original issue is that themes aren't supported yet, and are coming in the upcoming 3.0 release.

@joshbuker
Copy link
Author

joshbuker commented Mar 8, 2023

For folks looking to use dark theme before 3.0 gets released, update your files as follows:

_config.yml

# Disable using the latest Minima release
#theme: minima
# And instead pull straight from GitHub via jekyll remote theme
remote_theme: jekyll/minima

plugins:
  - jekyll-seo-tag
  - jekyll-feed
  - jekyll-remote-theme

minima:
  skin: dark

Gemfile

group :jekyll_plugins do
  gem 'jekyll-seo-tag'
  gem 'jekyll-feed'
  gem 'jekyll-remote-theme'
end

@jekyll jekyll locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants