-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SASS is deprecating the ability to use a / (slash) for division. #709
Comments
I've been getting the same: 190 │ padding-left: $spacing-unit / 2;
│ ^^^^^^^^^^^^^^^^^
╵
../../../../minima-2.5.1/_sass/minima/_base.scss 190:19 @content
minima.scss 38:5 media-query()
../../../../minima-2.5.1/_sass/minima/_base.scss 186:3 @import
minima.scss 48:3 @import
/home/charlie/g/cooksey.io/assets/main.scss 1:9 root stylesheet
Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
Recommendation: math.div($spacing-unit, 3) or calc($spacing-unit / 3)
More info and automated migrator: https://sass-lang.com/d/slash-div
╷
244 │ padding: ($spacing-unit / 3) ($spacing-unit / 2);
│ ^^^^^^^^^^^^^^^^^
╵
../../../../minima-2.5.1/_sass/minima/_base.scss 244:15 @import
minima.scss 48:3 @import
/home/charlie/g/cooksey.io/assets/main.scss 1:9 root stylesheet
Warning: 6 repetitive deprecation warnings omitted. |
@cdcooksey This has been addressed on the You have multiple options at your disposal:
|
Thank you providing a workaround, it was annoying to see the warning on every build. Looking forward to the next release! |
Appreciate your clear response @ashmaroli. I have been searching for an answer on this issue. |
This has been bothering me as well until finding this. Not being familiar with Jekyll or Sass much then presented with immediate errors first run with Just my 2-cents. I do love Jekyll. Seriously. A lot. |
Ah, there are breaking changes currently merged into main. Considering there is an easy workaround, it makes more sense why creating a patch release for this is a low priority. It would have been a good idea to keep those breaking changes out of main until they were ready to ship, but that's a lesson for the future. |
This issue has been automatically marked as stale because it has not been commented on for at least two months. The resources of the Jekyll team are limited, and so we are asking for your help. If this is a bug and you can still reproduce this error on the If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial. This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions. |
We have temporarily hidden the warnings in our build (raspberrypi/documentation#2866) but would definitely appreciate an upstream fix. Yes, it's not crucial, but it is a horrible user experience. |
This issue has been automatically marked as stale because it has not been commented on for at least two months. The resources of the Jekyll team are limited, and so we are asking for your help. If this is a bug and you can still reproduce this error on the If this is a feature request, please consider whether it can be accomplished in another way. If it cannot, please elaborate on why it is core to this project and why you feel more than 80% of users would find this beneficial. This issue will automatically be closed in two months if no further activity occurs. Thank you for all your contributions. |
This is a dumb reply to keep @jekyllbot happy. The issue still persists, and is relevant. |
It seems to be in only one place, why not checkout the last release, make the change, and then do a patch release from there? Then it can be fixed on main later? Git's flexible, this shouldn't be that big of a deal to fix. |
Wasn't this addressed by #700? |
Any plan still for a new release with the fixes? |
Yeah looks like it. Id prever a new release. whats the issue with making new releases? you dont experiment in main, that's where branches are for. |
The last release was in 2019, 4 years ago... Is Minima in need of a maintainer? I would normally volunteer, but I'm already hilariously behind on maintaining other projects. |
Could somebody just make a release and gem? plz :) |
During site deployment, i get deprecation warnings. Similiar to the suggested fix here:
#705 seems to indicate the same issue im having
running the suggested command wont work remote, as these codes are inside the downloaded template. I would love to get rid of minima, but seeing its a default template and pretty minimal, this needs fixing for more people. Whatever a default would be, more people stumble upon this problem right?
The text was updated successfully, but these errors were encountered: