Provide exclude mechanism for minima #128

dirkgomez · 2017-05-08T15:58:21Z

Put this into your front matter to exclude pages:

exclude: true

ashmaroli · 2017-05-08T16:47:53Z

To exclude a page from being processed, simply add published: false to the front matter

pathawks · 2017-05-08T16:55:24Z

@ashmaroli It looks like this is about excluding a page from the default navigation, rather than preventing it from being published.

benbalter

We'll also need to update the docs.

benbalter · 2017-05-08T18:52:02Z

_includes/header.html

@@ -21,7 +21,7 @@
        <div class="trigger">
          {% for path in page_paths %}
            {% assign my_page = site.pages | where: "path", path | first %}
-            {% if my_page.title %}
+            {% if my_page.title and !my_page.exclude != true %}


I'd recommend this be something more descriptive, like exclude_from_nav to prevent collisions with existing YAML.

Where in the docs would I put that? I can't find a section that seems a good fit to me (and I'm a Jekyll newbie, so a bit lost anyway).

@dirkgomez Looking at the existing content, I would expect to see it as a new h3 in the Usage section

ashmaroli · 2017-05-09T02:11:45Z

It looks like this is about excluding a page from the default navigation

@pathawks You're right. My bad..

Strangehill · 2017-05-22T11:37:33Z

I find whitelisting pages with an include field rather than blacklisting with an exclude more useful more often.

dirkgomez · 2017-05-22T12:21:58Z

Wouldn't that be a breaking change though?

Strangehill · 2017-05-22T12:25:26Z

Oh, that's right. Good point.

benbalter · 2017-06-02T13:57:26Z

_includes/header.html

@@ -21,7 +21,7 @@
        <div class="trigger">
          {% for path in page_paths %}
            {% assign my_page = site.pages | where: "path", path | first %}
-            {% if my_page.title %}
+            {% if my_page.title and !my_page.exclude_from_nav != true %}


Shouldn't this be == true?

I think the issue is the unary not (!), which I understand is not supported in liquid. I believe this is sufficient:

if my_page.title and my_page.exclude_from_nav != true

Unfortunately, == false isn't available to us here because of a defect with truthiness in liquid/ruby with respect to booleans, nulls, empty string, uninitialized values, and so on...

@dirkgomez I tested and confirmed @ashawley's logic to be correct. In the current state (8fb7b81) the boolean is working opposite from desired behavior.

Also, it is up to you if you care or not, but I noticed your first commit (41529ce) was done with a different e-mail address than the others, and that e-mail address is not associated with your GitHub account. You may wish to squash/rebase (then force-push) to bring them all under one address or to add your other e-mail address to your GitHub account so it is recognized as yours.

adamvoss · 2017-06-07T01:06:07Z

_includes/header.html

@@ -21,7 +21,7 @@
        <div class="trigger">
          {% for path in page_paths %}
            {% assign my_page = site.pages | where: "path", path | first %}
-            {% if my_page.title %}
+            {% if my_page.title and my_page.exclude_from_nav == true %}


Should be,

and my_page.exclude_from_nav != true

Thanks for sticking with this. I know from experience getting boolean logic right can be a pain :-)

Put this into your front matter to exclude pages from showing up in the navigation: exclude_from_nav: true

dirkgomez · 2017-06-07T14:56:49Z

Amended the commits accordings - and thank you for the patience, still grappling with Jekyll.

ashawley · 2017-06-07T15:43:55Z

Why isn't whitelisting with header_pages sufficient?

dirkgomez · 2017-06-07T16:15:36Z

Looks very similar indeed, how do I use header_pages?

ashawley · 2017-06-07T16:30:52Z

Looks like #52 documented it in the config but not the README

dirkgomez · 2017-06-07T17:59:53Z

ashawley is right, I'm closing this pull request.

ashawley · 2017-06-07T19:29:20Z

For the record, I wasn't opposed to this change. I was just wondering why the question wasn't raised about the overlap with header_pages. It takes a lot of humility to close a PR and then even further offer to make the documentation fix. Good on you, dirkgomez!

To be honest, I would still entertain this improvement. I predict it will come up again for scenarios where blacklisting may be easier to maintain than whitelisting (with header_pages).

adamvoss · 2017-06-07T19:47:09Z

#134 continues from the discussion here by adding documentation for header_pages to **README.md.
(Commenting so the issues are linked on GitHub.)

@ashawley Like @dirkgomez I had need for something like this. I agree in not being opposed to this, but I am not sure there is enough reason to push for it now either. If you look at the behavior of minima when there are lots of nav links, I think from a practical standpoint the number of desired nav links will be kept low, favoring a whitelist approach. Plus, header_pages gives the added benefit of defining order.

The main advantage of the approach in this PR would be the resilience to file moves/renames.

benbalter reviewed May 8, 2017

View reviewed changes

adamvoss mentioned this pull request Jun 2, 2017

Document how to opt a page out benbalter/jekyll-titles-from-headings#19

Closed

benbalter reviewed Jun 2, 2017

View reviewed changes

adamvoss suggested changes Jun 7, 2017

View reviewed changes

Be able to exlude pages from the default navigation.

bc0ffd3

Put this into your front matter to exclude pages from showing up in the navigation: exclude_from_nav: true

dirkgomez closed this Jun 7, 2017

jekyll locked and limited conversation to collaborators Apr 30, 2019

jekyllbot added the frozen-due-to-age label Apr 30, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide exclude mechanism for minima #128

Provide exclude mechanism for minima #128

dirkgomez commented May 8, 2017

ashmaroli commented May 8, 2017

pathawks commented May 8, 2017

benbalter left a comment

benbalter May 8, 2017

dirkgomez May 9, 2017

adamvoss Jun 2, 2017

ashmaroli commented May 9, 2017

Strangehill commented May 22, 2017

dirkgomez commented May 22, 2017

Strangehill commented May 22, 2017

benbalter Jun 2, 2017

ashawley Jun 5, 2017

adamvoss Jun 5, 2017

adamvoss Jun 7, 2017

dirkgomez commented Jun 7, 2017

ashawley commented Jun 7, 2017

dirkgomez commented Jun 7, 2017

ashawley commented Jun 7, 2017

dirkgomez commented Jun 7, 2017

ashawley commented Jun 7, 2017

adamvoss commented Jun 7, 2017

Provide exclude mechanism for minima #128

Provide exclude mechanism for minima #128

Conversation

dirkgomez commented May 8, 2017

ashmaroli commented May 8, 2017

pathawks commented May 8, 2017

benbalter left a comment

Choose a reason for hiding this comment

benbalter May 8, 2017

Choose a reason for hiding this comment

dirkgomez May 9, 2017

Choose a reason for hiding this comment

adamvoss Jun 2, 2017

Choose a reason for hiding this comment

ashmaroli commented May 9, 2017

Strangehill commented May 22, 2017

dirkgomez commented May 22, 2017

Strangehill commented May 22, 2017

benbalter Jun 2, 2017

Choose a reason for hiding this comment

ashawley Jun 5, 2017

Choose a reason for hiding this comment

adamvoss Jun 5, 2017

Choose a reason for hiding this comment

adamvoss Jun 7, 2017

Choose a reason for hiding this comment

dirkgomez commented Jun 7, 2017

ashawley commented Jun 7, 2017

dirkgomez commented Jun 7, 2017

ashawley commented Jun 7, 2017

dirkgomez commented Jun 7, 2017

ashawley commented Jun 7, 2017

adamvoss commented Jun 7, 2017