Look for site.github.url if it exists

[parkr]

This fixes #17. /cc @benbalter

This requires a change in the jekyll new template, sadly, namely in the listing of site.posts. We could potentially ship an include for posts_list or something so we don't have to update it in Jekyll in the future?

[benbalter]

If the user sets a base url, wouldn't this result in http://username.github.io/project/project/?

[benbalter]

We need to assume users are going to look to the default theme as an example of how they should build their own site... I'd really rather avoid this complexity if possible. Is there any way to do this without assigns?

[parkr]

If the user sets a base url, wouldn't this result in http://username.github.io/project/project/?

What do you mean by this? custom_url is site.url + site.baseurl, and full_base_url is site.github.url OR custom_url, if site.github.url doesn't exist.

Is there any way to do this without assigns?

We need to allow plugins or provide a filter like this in Jekyll or the jekyll-github-metadata plugin. Due to the scope at render time (starts with just the page content, then includes each successive layout in turn), we have to calculate this each time. Alternatively, Jekyll could introduce site.full_url.

[benbalter]

LGTM.

[ashmaroli]

ever since this got merged, I'm no longer able to access http://localhost:4000
I have to instead go to http://localhost:4000/minima/index to reach the example site

/cc @parkr, @benbalter

[benbalter]

@parkr did you mean to include a baseurl by default?

[parkr]

No.

[parkr]

Well.

[parkr]

It is useful for testing.

[ashmaroli]

we'll hv to update readme to reflect this change..

[anthonyjsmith]

I think that having a full URL (with site.url) in the stylesheet link causes a default Jekyll site to look for a stylesheet at http://example.com/css/main.css, which obviously doesn't exist. See this Jekyll Talk thread.