Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS customization docs #342

Closed
wants to merge 1 commit into from
Closed

Fix CSS customization docs #342

wants to merge 1 commit into from

Conversation

ksm
Copy link

@ksm ksm commented Feb 3, 2019

I was trying to customize my Jekyll blog's CSS and found that the path for the main scss file (for minima 2.5.0) is assets/main.scss, and that's what you have to recreate in your own Jekyll repo to get customizations to work. It is not /assets/css/style.scss (creating this does nothing).

Here's what I mean: ksm/blog.mazur.me@b99369e. This commit got CSS overrides to work on my blog.

I was trying to customize my Jekyll blog's CSS and found that the path for the main scss file (for minima 2.5.0) is assets/main.scss, and that's what you have to recreate in your own Jekyll repo to get customizations to work. It is not /assets/css/style.scss (creating this does nothing).
@ashmaroli
Copy link
Member

@ksm The changes you're seeing are recent changes for the next major version of this theme:
Ref: 70aaede

The README for the version you're using is already included in the gem.
Running bundle show minima will give you the path to the gem on your system. You can find the README for that version at the resulting path.

@ashmaroli ashmaroli closed this Feb 4, 2019
@ksm
Copy link
Author

ksm commented Feb 4, 2019

@ashmaroli Sorry for the confusion! I assumed that the readme matched the newest official version of 2.5.0. Wasn't aware there's a pre-release. Thanks for the quick turnaround @ashmaroli. ✨

@ksm ksm deleted the patch-1 branch February 4, 2019 15:47
@ashmaroli
Copy link
Member

@ksm There's no need to be sorry.
I've opened a PR #343 to place a disclaimer in our README. Hopefully that should reduce the confusion..

@jekyll jekyll locked and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants