Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gemspec to require at least Jekyll 3.3 #59

Merged
merged 1 commit into from Oct 6, 2016
Merged

Update gemspec to require at least Jekyll 3.3 #59

merged 1 commit into from Oct 6, 2016

Conversation

ashmaroli
Copy link
Member

replacing development_dependency with runtime_dependency to require ~> Jekyll 3.3

@benbalter
Copy link
Contributor

@ashmaroli any interest in making the same change upstream? https://github.com/jekyll/jekyll/blob/master/lib/theme_template/theme.gemspec.erb#L15

@ashmaroli
Copy link
Member Author

any interest in making the same change upstream?

sure.. no problems at all..

@ashmaroli
Copy link
Member Author

@benbalter, please restart the test on Travis, now that the Jekyll 3.3.0 has been released.

@benbalter
Copy link
Contributor

@jekyllbot: merge +minor.

@jekyllbot jekyllbot merged commit 174d81d into jekyll:master Oct 6, 2016
jekyllbot added a commit that referenced this pull request Oct 6, 2016
@jekyllbot
Update history to reflect merge of #59 [ci skip]
3c1b625
@benbalter
Copy link
Contributor

Thanks @ashmaroli! 😄 🦃 🍔

@ashmaroli ashmaroli mentioned this pull request Nov 15, 2016
Merged
@ashmaroli ashmaroli deleted the require-330 branch July 28, 2017 15:09
@jekyll jekyll locked and limited conversation to collaborators Apr 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@benbalter benbalter benbalter approved these changes

Assignees
No one assigned
Labels
enhancement frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashmaroli @benbalter @jekyllbot