do not run tests on TravisCI which are also run as GitHub Actions #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests except for BrowserStack tests were executed both on TravisCI and as GitHub Actions. As GitHub Actions has been prooven to be stable we can remove duplicated tests now and only run BrowserStack tests on TravisCI. We should migrate them to GitHub Actions as well in a follow-up merge request to reduce complexity.
jelhan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests except for BrowserStack tests were executed both on TravisCI and as GitHub Actions. As GitHub Actions has been proven to be stable we can remove duplicated tests now and only run BrowserStack tests on TravisCI. We should migrate them to GitHub Actions as well in a follow-up merge request to reduce complexity.
GitHub Actions were introduced in #320. In that pull request we decided to keep the existing CI pipeline on TravisCI until GitHub Actions have been proven to provide similar or better stability. I think that's what we have seen.
Faced some issues when trying to migrate the BrowserStack tests to GitHub Actions. Therefore they weren't migrated as part of #320. Details can be found in the discussion of that pull request.