Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring notes #3

Open
JelleBouma opened this issue Dec 30, 2020 · 0 comments
Open

Refactoring notes #3

JelleBouma opened this issue Dec 30, 2020 · 0 comments
Assignees
Labels

Comments

@JelleBouma
Copy link
Owner

JelleBouma commented Dec 30, 2020

HWID
InfinityScript 1.5.3 has an entity field HWID which could replace a lot of DGAdmin code for getting the HWID.
However this field holds a 32 digit hexadecimal HWID which is completely different from the 24 digit hexadecimal HWID that DGAdmin uses.
The DGAdmin HWID does seem to work well, it keeps out some people with a HWID equal to zero, who are presumably hackers. While everyone I know does not have a zero HWID.
This left me 3 options:

  1. Refactor it regardless, even though this will ruin existing permissions and may not work as well as the HWID DGAdmin uses.
  2. Use both HWIDs, leading to more code and possibly more problems, but might be even better at stopping cheaters.
  3. Leave it as is.

I opted for the third option here.

@JelleBouma JelleBouma self-assigned this Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant