-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twitter to X: Please replace icon with "X", change text to "Twitter (X)", etc. #3
Comments
Hi Luke, I've noticed that the X brand icon is not available for font awesome 5 (which is what I'm currently using to test). What version are you currently using? Not sure what would be the best way to go about this; it would probably require a v2 of the plugin. Currently it's using FA5 with I think putting out a v2 with FA6 would additionally require people to set up a FA account + their kits. As far as I have seen there is a limited "free plan". Any thoughts? |
Why don't using the "ETmodules" font instead? This would solve the dependency for the Font Awesome plugin and you have the X icon already. Just following the "Social Icons" module. |
Hi Torsten, thanks for the suggestion. Having a quick look at the available icons it doesn't seem that all icons are available that the plugin currently supports (for example: telegram, tiktok, twitch to name a few). However, dropping Fontawesome as a dependency and going for another (open source) icon library might be a good idea going forward. |
The page is not up-to-date. I just checked the Social Media module in the recent Divi and all three are supported. This is the complete list: But compared to your list, there are indeed some missing: |
Elegant Themes have updated it in the core footer icon set. So this makes me wonder if you could inherit that one instead of sourcing from FA? |
On the above list https://rumble.com/ is missing. |
Can keep internal ref/name the same. Mostly the icon.
The text was updated successfully, but these errors were encountered: