Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter to X: Please replace icon with "X", change text to "Twitter (X)", etc. #3

Open
lsthompson opened this issue Mar 25, 2024 · 6 comments

Comments

@lsthompson
Copy link
Contributor

Can keep internal ref/name the same. Mostly the icon.

@lsthompson lsthompson changed the title Twitter to X: Please replace icon with "X", change text to "Twitter(X)", etc. Twitter to X: Please replace icon with "X", change text to "Twitter (X)", etc. Mar 25, 2024
@jelleroorda
Copy link
Owner

Hi Luke,

I've noticed that the X brand icon is not available for font awesome 5 (which is what I'm currently using to test).

What version are you currently using? Not sure what would be the best way to go about this; it would probably require a v2 of the plugin. Currently it's using FA5 with fab fa-icon-name, but that would all need to be converted to fa-brands fa-icon-name.

I think putting out a v2 with FA6 would additionally require people to set up a FA account + their kits. As far as I have seen there is a limited "free plan".

Any thoughts?

@Zodiac1978
Copy link
Contributor

Zodiac1978 commented Apr 17, 2024

Why don't using the "ETmodules" font instead? This would solve the dependency for the Font Awesome plugin and you have the X icon already. Just following the "Social Icons" module.

@jelleroorda
Copy link
Owner

Hi Torsten, thanks for the suggestion.

Having a quick look at the available icons it doesn't seem that all icons are available that the plugin currently supports (for example: telegram, tiktok, twitch to name a few).

However, dropping Fontawesome as a dependency and going for another (open source) icon library might be a good idea going forward.

@Zodiac1978
Copy link
Contributor

The page is not up-to-date. I just checked the Social Media module in the recent Divi and all three are supported.

This is the complete list:
Amazon
Bandcamp
Behance
BitBucket
Buffer
dribbble
Facebook
Flickr
FlipBoard
Foursquare
GitHub
Goodreads
Google
Houzz
Instagram
Itunes
Last.fm
Linie
LinkedIn
Medium
Meetup
MySpace
Odnoklassniki
Patreon
Periscope
Pinterest
Quora
Reddit
ResearchGate
RSS
skype
Snapchat
SoundCloud
Spotify
Steam
Telegram
TikTok
TripAdvisor
tumblr
Twitch
X
Vimeo
VK
Weibo
Whatsapp
XING
Yelp
Youtube

But compared to your list, there are indeed some missing:
Apple, Xing, Discord

@lsthompson
Copy link
Contributor Author

Elegant Themes have updated it in the core footer icon set.

So this makes me wonder if you could inherit that one instead of sourcing from FA?

@techsurrusr
Copy link

On the above list https://rumble.com/ is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants