Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Has method #100

Merged
merged 4 commits into from
Apr 29, 2023
Merged

Add Has method #100

merged 4 commits into from
Apr 29, 2023

Conversation

gozeloglu
Copy link
Contributor

@gozeloglu
Add Has method
db0c363 
* `Has` method is implemented and tested.

* This changes fixes jellydator#99.

Signed-off-by: Gökhan Özeloğlu <gozeloglu@gmail.com>
@gozeloglu
Replace time.Minute with NoTTL in test
48bef0c 
Signed-off-by: Gökhan Özeloğlu <gozeloglu@gmail.com>
@gozeloglu
Update README
a827fdf 
Signed-off-by: Gökhan Özeloğlu <gozeloglu@gmail.com>
swithek
swithek reviewed Apr 28, 2023
View reviewed changes
Copy link
Contributor

@swithek swithek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A few small changes are needed.

cache_test.go Outdated Show resolved Hide resolved
cache_test.go Outdated Show resolved Hide resolved
@gozeloglu
Refactor Test_Cache_Has
4e138a6 
* Renamed `TestCache_Has` -> `Test_Cache_Has`.

* Struct-based tests replaced with map-based test.

Signed-off-by: Gökhan Özeloğlu <gozeloglu@gmail.com>
@gozeloglu gozeloglu requested a review from swithek April 28, 2023 21:34
swithek
swithek approved these changes Apr 29, 2023
View reviewed changes
Copy link
Contributor

@swithek swithek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

@swithek swithek merged commit 17d45be into jellydator:master Apr 29, 2023
@lesichkovm
Copy link

Thank you @gozeloglu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swithek swithek swithek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a method to check if a key exists
3 participants
@gozeloglu @lesichkovm @swithek