Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add treesitter support #103

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Conversation

hsanson
Copy link
Contributor

@hsanson hsanson commented Mar 7, 2024

This PR uses treesitter hurl parser to locate the HURL entry at the current cursor position. This is more efficient and reliable than parsing based on HTTP verbs and allows executing HurlRunnerAt from any place as long as it is inside a HURL entry.

This PR uses treesitter hurl parser to locate the HURL entry at the
current cursor position. This is more efficient and reliable than
parsing based on HTTP verbs and allows executing HurlRunnerAt from any
place as long as it is inside a HURL entry.
Copy link

changeset-bot bot commented Mar 7, 2024

⚠️ No Changeset found

Latest commit: eecbe11

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

sweep-ai bot commented Mar 7, 2024

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Commit messages should be descriptive and provide a clear explanation of the changes made.
  • Apply: Author names should be consistent and use proper formatting.
  • Apply: Code should be properly formatted and follow a consistent style guide.
  • Apply: There should be no unnecessary whitespace or trailing spaces in the code.
  • Apply: Variable and function names should be meaningful and descriptive.

This is an automated message generated by Sweep AI.

@jellydn
Copy link
Owner

jellydn commented Mar 8, 2024

Thanks @hsanson for your PR. This looks good. I will take a try and merge this sometime this week.

Copy link
Owner

@jellydn jellydn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @hsanson

@jellydn jellydn merged commit 6a16d4f into jellydn:main Mar 9, 2024
6 checks passed
@jellydn
Copy link
Owner

jellydn commented Mar 9, 2024

@all-contributors add @hsanson for code,doc.

Copy link
Contributor

@jellydn

I've put up a pull request to add @hsanson! 🎉

@jellydn
Copy link
Owner

jellydn commented Mar 9, 2024

FYI - I've tested the run at entry and it doesn't work so I've reverted this util function.

f77a52f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants