-
Notifications
You must be signed in to change notification settings - Fork 221
Fix DLNA and HDHR for Traefik Docker compose #168
Conversation
Based on the changes proposed by @Artiume - Moved Traefik and Jellyfin to a single docker-compose.yml - Removed some config items - Added functional host networking so DLNA and LiveTV work - Used static rules to point to docker host from Traefik network - Changed docker-compose version to 3.5 (to support network name) - there are other workarounds but this is more copy/paste friendly
I thought so too, but all the Traefik docs show it this way, and it seems to be working for me locally, so I'm going to leave it unless someone reports it being broken. https://github.com/containous/traefik/blob/v1.7/docs/user-guide/docker-and-lets-encrypt.md |
Grouping here is weird - alternative to this would be to move Certbot instructions under the RP they apply to (Apache/HAproxy/Nginx)...
Sorry @oddstr13 - my intention was to have atomic commits that could be reviewed independently (or thrown out) without making a bunch of PRs. The first commit is the real meat of this issue. I'll change to example.com and move reordering to another PR. Agree they should all be on their own pages - but that will also require someone to dissect lets encrypt into nginx and apache pages (or DRY and put it on its own page). |
@oddstr13 I think I'm going back on undoing the ordering - the current order makes no sense and is confusing:
My change does this (so at least the high level list of reverse proxies is consistent - certbot instructions for each proxy are moved to the bottom):
IMO, this is a reasonable stopgap solution until each RP is moved to its own page (and will hopefully help lots of the issues people are having with Traefik/--net=host. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the specifics of docker-compose or Træfik, but looks good to me.
Based on the changes proposed by @Artiume