This repository has been archived by the owner on Feb 28, 2022. It is now read-only.
Fix Various Issues With The fileorganizer Dialog #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the existing behavior of displaying "Error: null"
mark-monteiro
commented
Dec 11, 2019
| dlg.querySelector('#selectMedias').setAttribute('label', 'Movie'); | ||
| dlg.querySelector('[for="selectMedias"]').innerHTML = 'Movie'; | ||
| mediaSelector.setAttribute('label', 'Movie'); | ||
| if (mediaSelector && mediaSelector.setLabel) mediaSelector.setLabel('Movie'); |
There was a problem hiding this comment.
When the dialog first opens, the <label> element for the selector has not yet been created so we check for that here. The label text is still initialized correctly by the emby-select component when it loads using the label attribute value. See: https://github.com/jellyfin/jellyfin-web/blob/master/src/components/emby-select/emby-select.js#L151
mark-monteiro
commented
Dec 11, 2019
| } | ||
|
|
||
| // Show dialog | ||
| dialogHelper.open(dlg); |
There was a problem hiding this comment.
Open the dialog only after all other initialization has completed so that it is ready to be viewed
|
Alright - Now that the plug-in has been updated with the other reps, I'll review this one, and if it's good, we'll cut a release. |
anthonylavado
approved these changes
Dec 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several issues with the fileorganizer dialog:
NOTE: The version number for the plugin has not been updated here. I'm not sure how releases are performed and how changes should be coordinated with the existing PR #17