Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

Target 10.7 #49

Merged
merged 3 commits into from
Dec 3, 2020
Merged

Target 10.7 #49

merged 3 commits into from
Dec 3, 2020

Conversation

crobibero
Copy link
Collaborator

No description provided.

oddstr13
oddstr13 approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@oddstr13 oddstr13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the event stuff was just for logging events to the dashboard then?

All of that needs a proper overhaul in the server anyways.

@oddstr13 oddstr13 requested a review from a team December 3, 2020 17:22
@crobibero
Copy link
Collaborator Author

I'm assuming the event stuff was just for logging events to the dashboard then?

All of that needs a proper overhaul in the server anyways.

IIRC the websocket events only listened to very specific keys so these events were never actually displayed?

@oddstr13 oddstr13 changed the title 10.7 Target Jellyfin 10.7 Dec 3, 2020
@oddstr13
Copy link
Contributor

oddstr13 commented Dec 3, 2020

There has been a fair bit of changes around the event stuff in web, but I don't remember how far back those changes are.

@oddstr13 oddstr13 changed the title Target Jellyfin 10.7 Target 10.7 Dec 3, 2020
@oddstr13 oddstr13 merged commit fb49c6f into master Dec 3, 2020
@crobibero crobibero deleted the 10.7 branch December 15, 2020 00:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oddstr13 oddstr13 oddstr13 approved these changes

@BaronGreenback BaronGreenback BaronGreenback approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crobibero @oddstr13 @BaronGreenback @daullmer