[TheOneric] Deprecate manual brotli decompression #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't have much benefit but comes with a maintenance cost as we either need to keep patching upstream's js implementation for use in JSO — which also bloats binary size by including two copies of brotli and its default dict — or use the C implemntation from JS which requires boilerplate in both C and JS and also additional JS polyfills to keep e.g. the fontname extraction working. The browser's in-built support for Content-Encoding is more felxible, faster and simpler to use. Cherry-picked from: libass@e459c8e
dmitrylyzo
force-pushed
the
deprecate-brotli
branch
from
a3d0215
to
bde0b95
Compare
thornbill
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling from the upstream.
Original author: TheOneric
Non-PRed commit.