Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Chinese subtitles dispaly as 口(▢ a hollow square) #497

Closed
HySand opened this issue Jul 22, 2022 · 5 comments
Closed

Some Chinese subtitles dispaly as 口(▢ a hollow square) #497

HySand opened this issue Jul 22, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@HySand
Copy link

HySand commented Jul 22, 2022

Describe the bug

Only a few of words show wrongly.
e.g.
IMG_1058
ARCANE S1E4 12:23, using Subrip subtitle. The 口 in the subtitle should be "稳", which display correctly on Jellyfin web client:
无标题
Missing font?

Application version

1.0.0(76)

Where did you install the app from?

TestFlight

Device information

Both iPhone XS MAX and iPad 2019

OS version

IOS 15.6, iPad OS 15.6

Jellyfin server version

10.8.1 unofficial docker(nyanmisaka/jellyfin) which adds addtional chinese support.

@HySand HySand added the bug Something isn't working label Jul 22, 2022
@PangMo5 PangMo5 self-assigned this Jul 23, 2022
@PangMo5
Copy link
Member

PangMo5 commented Jul 23, 2022

Thank you for leaving the issue.
We will support setting the subtitle font.
I don't know exactly, but I think the function can solve the problem.

@LePips
Copy link
Member

LePips commented Jul 29, 2022

Sadly, this isn't necessarily fixed by choosing a different font. I only tested a few fonts on the same media and still get the box or even a different character in that space. Due to this finding, this is simply a VLCKit issue and we can't do anything about it. However, you may be able to find a font that displays it correctly that I didn't test with.

IMG_9466

@LePips LePips closed this as completed Jul 29, 2022
@HySand
Copy link
Author

HySand commented Jul 31, 2022

Sadly, this isn't necessarily fixed by choosing a different font. I only tested a few fonts on the same media and still get the box or even a different character in that space. Due to this finding, this is simply a VLCKit issue and we can't do anything about it. However, you may be able to find a font that displays it correctly that I didn't test with.

IMG_9466

I think that should be caused by the wrong font.
Swiftfin use fonts for traditional Chinese even when choosing a simplified Chinese subtitle.

Here is what i found form a font site.

Simplifiled Chinese words with PingFang SC Medium (Simplified Chinese font come with Apple mobile devices)
image
Simplified Chinese words with PingFang TC Medium (Traditional Chinese font come with Apple mobile devices)
image
Traditional Chinese words with PingFang TC Medium (Traditional Chinese font come with Apple mobile devices)
image

There‘s no corresponding words (like "稳") for Simplified Chinese in Traditional Chinese fonts. That's why it display worngly when I select the subtitle in Simplified Chinese.

You can see some differences between two fonts from the last word “全”.

PingFang SC
image
PingFang TC
image

@LePips
Copy link
Member

LePips commented Jul 31, 2022

Thank you for your insight as I don't know the differences between Simplified and Traditional as an only English speaker. You may be able to find a font to fix the characters in the next release then! 🎉

@zhoudongliang
Copy link

求字幕的字体和颜色设置方法
19717610@qq.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants