-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support subtitle font selection #498
Conversation
PangMo5
commented
Jul 23, 2022
•
edited
edited
- Add subtitle font selection in Settings (Default value: .systemFont)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's quite fun to play around with the fonts! However, I get a crash from opengl every other time playback is started. Probably from the Selector(("setTextRendererFont:"))
as this is currently a workaround for VLCKit. I'm not comfortable shipping this because of these crashes.
I would also like to find out if this directly solves the issue. The author of the issue isn't necessarily correct that it's a "missing font" issue, it just looks like the font doesn't support that character. I know that some other fonts might have these missing characters but we would need to test.
I didn't experience the related crash. |
Sorry, I haven't been able to test on a physical device because I've been out of town so I'll be able to do that later. I do have that exact episode so I might be able to load up the exact word. The crashing occurred on any font. |
Okay, testing on a real device hasn't crashed on changing fonts. All good for normal use. |
Sadly, I don't think this necessarily fixes the original issue. I've tested that same media on different fonts and still get the box character or another character in that space. Due to that, I think this is a VLCKit issue so we can close the issue. Nonetheless, this is still a really cool feature. |
I see :d |