Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search Enhancements #108

Merged
merged 10 commits into from
Jul 15, 2021
Merged

Search Enhancements #108

merged 10 commits into from
Jul 15, 2021

Conversation

PangMo5
Copy link
Member

@PangMo5 PangMo5 commented Jul 15, 2021

Changed

  • Add suggestions (Same API as Jellyfin Web)
  • Implement search by ItemType
  • Redesign SearchBarView

Previews

@PangMo5 PangMo5 added the enhancement New feature or request label Jul 15, 2021
@PangMo5 PangMo5 requested a review from acvigue July 15, 2021 16:02
@PangMo5 PangMo5 self-assigned this Jul 15, 2021
@PangMo5
Copy link
Member Author

PangMo5 commented Jul 15, 2021 •
edited

Why is there a ci build error? 🤔
I have confirmed that build normally on the local Xcode.

@acvigue
Copy link
Member

acvigue commented Jul 15, 2021

Why is there a ci build error? 🤔
I have confirmed that build normally on the local Xcode.

LibrarySearchView.swift:75:25: error: variable used within its own initial value
let items = items(for: viewModel.selectedItemType)

acvigue
acvigue requested changes Jul 15, 2021
View reviewed changes
JellyfinPlayer/Components/PortraitItemView.swift Outdated Show resolved Hide resolved
JellyfinPlayer/LibrarySearchView.swift Outdated Show resolved Hide resolved
JellyfinPlayer/LibrarySearchView.swift Outdated Show resolved Hide resolved
JellyfinPlayer/LibrarySearchView.swift Show resolved Hide resolved
JellyfinPlayer/LibrarySearchView.swift Outdated Show resolved Hide resolved
Shared/Typings/Typings.swift Show resolved Hide resolved
@PangMo5 PangMo5 requested a review from acvigue July 15, 2021 17:30
acvigue
acvigue previously approved these changes Jul 15, 2021
View reviewed changes
@PangMo5
Copy link
Member Author

PangMo5 commented Jul 15, 2021

I don't know why there's no build error in my mac. lol
I'll re-clone the repo and build it.

@acvigue
Copy link
Member

acvigue commented Jul 15, 2021

We use a different, stricter version of xcodebuild. Best to just resolve the error and move on.

@acvigue
Copy link
Member

acvigue commented Jul 15, 2021

Rerunning ci with newer version of macOS as runner.

@sonarcloud
Copy link

sonarcloud bot commented Jul 15, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
12.5% 12.5% Duplication

@acvigue
Copy link
Member

acvigue commented Jul 15, 2021

shut up sonar cloud

@PangMo5
Copy link
Member Author

PangMo5 commented Jul 15, 2021

🎉

@acvigue
Copy link
Member

acvigue commented Jul 15, 2021

fix lint and ill merge

@acvigue acvigue merged commit c50b536 into jellyfin:main Jul 15, 2021
@PangMo5 PangMo5 deleted the PangMo5/enhanced-search branch July 23, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acvigue acvigue acvigue left review comments

Assignees

@PangMo5 PangMo5

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PangMo5 @acvigue