Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QOL - Set server keyboard for URL input #114

Merged
merged 2 commits into from
Jul 22, 2021

Conversation

LePips
Copy link
Member

@LePips LePips commented Jul 22, 2021

Quality of life improvement to have the server textfield keyboard to be for URL input.

@LePips LePips requested a review from acvigue as a code owner July 22, 2021 05:13
@LePips LePips changed the title QOL - Set server keyboard to url QOL - Set server keyboard for URL input Jul 22, 2021
@PangMo5
Copy link
Member

PangMo5 commented Jul 22, 2021

LGTM.
Can you also apply it to ConnectToServerView for tvOS?

@sonarcloud
Copy link

sonarcloud bot commented Jul 22, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@acvigue
Copy link
Member

acvigue commented Jul 22, 2021

ah, smart. i like this!

@acvigue
Copy link
Member

acvigue commented Jul 22, 2021

ignore the ci, its broken lol

@acvigue acvigue merged commit 7931b2c into jellyfin:main Jul 22, 2021
@LePips LePips deleted the server-url-keyboard branch October 19, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants