SeriesItemView redesign #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed.
|
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
|
I don't think SonarCloud is suitable for SwiftUI lol |
|
THANK YOU. ive been meaning to do this. SonarCloud is useful for certain things and I need to finish setting it up properly |
acvigue
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Additionally, I think it seems better to use even number of padding for UI.
And recommended to use spacing param when using
VStack,HStack,LazyVStack, andLazyHStack.It is difficult to implement the desired UI when using the default value of
nil.These are met in this PR.
This will make it look more modern and regular UI.
Before
After