Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX - TvOS Rearrange Media Buttons #129

Merged
merged 3 commits into from
Aug 6, 2021

Conversation

LePips
Copy link
Member

@LePips LePips commented Aug 6, 2021

Rearranges the media buttons for some better ux.

Previously instead of requiring users to click -> scroll to play -> click they can now click straight through to play.

Also breaks the shared row of buttons into its own view.

@LePips LePips requested a review from acvigue as a code owner August 6, 2021 17:58
Copy link
Member

@acvigue acvigue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

791a7ae doesn't belong in this PR.

@LePips
Copy link
Member Author

LePips commented Aug 6, 2021

Sorry, will be consolidated after the other PR is dealt with.

@acvigue acvigue merged commit 7ca106f into jellyfin:main Aug 6, 2021
@sonarcloud
Copy link

sonarcloud bot commented Aug 6, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
5.9% 5.9% Duplication

@LePips LePips deleted the tvos-rearrange-media-buttons branch October 19, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants