Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Player - Positive Time Ticker #152

Merged
merged 2 commits into from
Aug 21, 2021

Conversation

LePips
Copy link
Member

@LePips LePips commented Aug 20, 2021

Adds the positive time (time spent watching media) to the video player.

From a UI perspective, this makes the video bar symmetrical with the positive on the left and the negative on the right, also centering the time slider. Making it look ✨ nice ✨.

From a UX perspective, this allows the watcher to see how much they have seen already. This is especially handy with anime and shows with intros as Jellyfin doesn't have "Skip intro" support (...yet, it's being discussed here and there). This is overall a good feature when scrubbing to a specific section of the media.

This also solves another problem: UI for scrubbing. Some players use thumbnails that pop up above the bar to show the picture at that current second (Youtube, when it works right) and some players pop up a view showing the seconds being scrubbed to (Quicktime I believe). I believe by just adding the positive time ticker we don't need anything to pop up.

The next steps for scrubbing are:

  • try and implement high speed scrubbing, sounds tedious but doable
  • better UI while scrubbing. My thoughts are to fade out the time jumps, play button, and dark overlay while scrubbing. This design mirrors some other players. However, if we want to implement thumbnails while scrubbing that's okay too but an entire feature of its own.

@LePips LePips requested a review from acvigue as a code owner August 20, 2021 15:01
@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@acvigue acvigue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

constraints look good, merging.

@acvigue acvigue merged commit 5fa1a5f into jellyfin:main Aug 21, 2021
@LePips LePips deleted the video-player-positive-time branch October 19, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants