Settings - Advanced Server View #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PangMo5
reviewed
Aug 21, 2021
acvigue
approved these changes
Aug 23, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the Server and User information to the top of the Settings, which I argue are the most important settings.
Also adds a view to show the server public settings and refresh the library from within the app.
For the user row which just has the username, it is the beginning of work to show more user information. I'm looking at mirroring something like the iCloud row in the iOS Settings app. I started working on it but the JellyfinAPI isn't getting and caching images correctly from the server. Spent too much time on that.
Also removes the ability to "Switch user" because it straight up didn't work as intended. I will look at that as well when creating the user view.
I wanted this to update the
HomeViewas well. However, the source of truth for media in the app is inHomeViewModel. I kind of want to restructure how we use singletons and view models because we're breaking MVVM design paradigms a bit (my fault too). This can be addressed by pull down to refresh as another feature.