Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tvOS fixes #170

Merged
merged 4 commits into from
Sep 22, 2021
Merged

tvOS fixes #170

merged 4 commits into from
Sep 22, 2021

Conversation

jhays
Copy link
Contributor

@jhays jhays commented Sep 22, 2021

This PR addresses some issues that were preventing a successful build for tvOS.

  • Fixed usage of getEpisodeLocator() which is optional
  • Removed usage of some functions on SeriesItemViewModel that are now private
  • Removed some items from tvOS target that appear to be created for iOS usage
  • Added some fill colors to ColorExtension that are not present on tvOS

While I was in there making some adjustments, I also addressed Issue #164

  • Corrected the Home tab's tag from duplicate .allMedia to .home

With these adjustments, the app will successfully build on tvOS.

@jhays jhays requested a review from acvigue as a code owner September 22, 2021 14:29
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

PangMo5
PangMo5 approved these changes Sep 22, 2021
View reviewed changes
Copy link
Member

@PangMo5 PangMo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution!

@jhays
Copy link
Contributor Author

jhays commented Sep 22, 2021

Seems there are some lint issues including on files I didn't alter in this PR- were there some new listing rules added?

LMK how to proceed. Thanks!

@LePips
Copy link
Member

LePips commented Sep 22, 2021 •
edited

You can ignore the linting. We haven't strongly enforced it and the linter will make its own PR after each PR with style fixes.

If we want to strongly enforce it, would be a great recommendation for the Contribution Guidelines discussion

@acvigue acvigue merged commit 13202d8 into jellyfin:main Sep 22, 2021
@jhays jhays deleted the jhays/tvos-fix branch September 22, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PangMo5 PangMo5 PangMo5 approved these changes

@LePips LePips LePips approved these changes

@acvigue acvigue Awaiting requested review from acvigue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jhays @LePips @PangMo5 @acvigue