Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tvOS library work - add All Media tab #172

Merged
merged 8 commits into from
Oct 2, 2021

Conversation

jhays
Copy link
Contributor

@jhays jhays commented Sep 29, 2021

  • Adds tvOS version of LibraryListView under All Media tab. Allows access of TV Shows and Movies.
  • Adds item title to PortraitItemElement, increases height of LatestMediaView to fit added titles
  • Adds a bunch of .ignoreSafeArea() to ensure background image & video playback fills full screen on tvOS
  • Removed a force unwrap that caused a crash from VideoPlayerViewController
  • Increased tvOS deployment target to 15

@jhays jhays requested a review from acvigue as a code owner September 29, 2021 22:21
@@ -42,15 +42,13 @@ struct LatestMediaView: View {
LazyHStack {
Spacer().frame(width: 45)
ForEach(items, id: \.id) { item in
if item.type == "Series" || item.type == "Movie" {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know why, but I had to remove this because Xcode started choking on this view and would not build. I tried commenting out various parts of this until I figured out that this was the culprit.

If this filtering is important, could we move it out of this view and filter down the items list before it gets here? Let me know its importance and if there is another strategy that could be used.

Copy link
Member

@PangMo5 PangMo5 Sep 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a46ed45

The same part of iOS has been modified in this commit.
It has been modified to filter at the API call timing(in ViewModel), so I don't think it matters if you just erase it.

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

No Coverage information No Coverage information
52.7% 52.7% Duplication

@anthonylavado anthonylavado merged commit c2d4508 into jellyfin:main Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants