-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tvOS library work - add All Media tab #172
Conversation
@@ -42,15 +42,13 @@ struct LatestMediaView: View { | |||
LazyHStack { | |||
Spacer().frame(width: 45) | |||
ForEach(items, id: \.id) { item in | |||
if item.type == "Series" || item.type == "Movie" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really know why, but I had to remove this because Xcode started choking on this view and would not build. I tried commenting out various parts of this until I figured out that this was the culprit.
If this filtering is important, could we move it out of this view and filter down the items list before it gets here? Let me know its importance and if there is another strategy that could be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same part of iOS has been modified in this commit.
It has been modified to filter at the API call timing(in ViewModel), so I don't think it matters if you just erase it.
SonarCloud Quality Gate failed.
|
PortraitItemElement
, increases height ofLatestMediaView
to fit added titles.ignoreSafeArea()
to ensure background image & video playback fills full screen on tvOSVideoPlayerViewController