Swiftgen and Clean up Localizable.strings

[PangMo5]

I apply Swiftgen for the new localization system.

The benefits written in Swiftgen repo.

• Avoid any risk of typo when using a String
• Free auto-completion
• Avoid the risk of using a non-existing asset name
• All this will be ensured by the compiler and thus avoid the risk of crashing at runtime.

Before

Text("Home")
Text("S\(String(item.parentIndexNumber ?? 0)):E\(String(item.indexNumber ?? 0))")

After

L10n.home.text
Text(L10n.seasonAndEpisode(item.parentIndexNumber ?? 0, item.indexNumber ?? 0))

For more information, see https://github.com/SwiftGen/SwiftGen.

• Apply Swiftgen
• Remove some unnecessary keys (ex: %@ • %@, Genres:)
• Modify all localizable.string according to the new rule
• Change all the string usage parts

If you have any additional opinions on localization, please give me.

I didn't touch the string, which was not translated before.

[PangMo5]

I recommend merging this PR quickly before localizable.strings is updated due to the Weblate.

[LePips]

Just as dev note: I had trouble with CocoaPods since I'm now using an M1 machine and had to run some commands from this thread: CocoaPods/CocoaPods#10220

I will document this

[LePips]

Also, the generated file has swiftlint ignore rules. Because of this I'm almost convinced to just scrap swiftformat and keep to swiftlint

[acvigue]

Is this PR ready to merge?

[LePips]

It should be, yes

[PangMo5]

Also, the generated file has swiftlint ignore rules. Because of this I'm almost convinced to just scrap swiftformat and keep to swiftlint

Oh, this is because I used the default template provided by Swiftgen.
I didn't have any other intentions.
We can also change it to SwiftFormat ignore rules if we want.
Is there any other reason to stop changing to SwiftFormat?

[LePips]

Is there any other reason to stop changing to SwiftFormat?

Oh no, I had just saw that I thought it would be a problem. Since it isn't, we're still good to go on SwiftFormat.

[PangMo5]

Is this PR ready to merge?

Now it's ready 😄

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
12.3% Duplication