iOS - Home Screen Pull To Refresh #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
PangMo5
approved these changes
Oct 21, 2021
There was a problem hiding this comment.
First of all, this method looks good temporarily.
But Swiftfin now supports iOS 15 or higher.
We can replace the HomeView's ScrollView with List and .listRowSeparator(.hidden).
After that, we can use refreshable.
|
@acvigue Could we get this merged please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a long discussion about home screen refresh in #123
What's funny is that I thought we were never able to do a pull to refresh on
ScrollViewbut then I found out https://github.com/siteline/SwiftUI-Introspect exists so we are able to access the underlyingUIScrollViewand add aUIRefreshControl. Right now it's "snappy" but I think that's okay for now.However, this is just intermediary work until I implement a proper
MediaManagerobject that "caches" the next up, resume, and "all received" items. I went down a long rabbit hole for an improper implementation of this but thought it wasn't worth it until I got that work done first. I am doing this right now because I have been needing something to update state of what I'm watching on the home screen. I may remove this in the future when I implementMediaManager, as it may be unnecessary.