Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default scheme #198

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Default scheme #198

merged 2 commits into from
Oct 28, 2021

Conversation

LePips
Copy link
Member

@LePips LePips commented Oct 24, 2021

Adds an option to set the default scheme, with http as default. This also autopopulates the scheme in the server connection field for clarity. Autopopulating the field is a better alternative to a footer with more text because it clutters the screen even more and did not look appealing.

http is default because it is strongly assumed that most people are just connecting to their local servers and that they don't have https configured. However, this can be changed through the BasicAppSettingsView (where reset is also located).

I added this to only iOS for now because I will get to revamping some of the tvOS UI shortly, before the next Testflight update.

@LePips LePips requested a review from acvigue as a code owner October 24, 2021 04:28
@LePips LePips self-assigned this Oct 24, 2021
@LePips LePips linked an issue Oct 24, 2021 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@LePips
Copy link
Member Author

LePips commented Oct 27, 2021

@acvigue Could we get this merged please?

@acvigue acvigue merged commit 1344e90 into jellyfin:main Oct 28, 2021
@LePips LePips deleted the default-http-option branch January 17, 2022 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve "Connect" Screen Tooltips
2 participants