Applying MVVM and Moya on some screens, Changed filter structure

[PangMo5]

Changed

• Add JellyfinAPI
• Add Filter struct, API related enums
• Add LibraryListViewModel, LibraryViewModel, LibrarySearchViewModel
• Change a specific toolbar to a navigation bar item.
• Separate LibraryView and LibraryListView.
• Change to present SettingsView as sheet

Known issues

- UI cannot be updated after loading when entering LibraryView in MovieItemView and EpisodeItemView.
(Since it works normally when entering from another screen, there seems to be a problem in the life cycle of the MovieItemView and EpisodeItemView.) -> Life cycle issues of SwiftUI(NavigationLink) solved as Lazy

And it seems that there are a lot of @State, @EnvironmentObject, and ObservableObject that are not currently used in a lot of code. It would be nice to increase the performance by refactoring the related code.

I'm sorry that the commits weren't cleaned up as I modified a lot of code at once.

[acvigue]

All library requests return 401

[PangMo5]

All library requests return 401

It is normal on the simulator, but it seems to return 401 on the actual device.
Could you please give me any Jellyfin API documentation?

[acvigue]

Try removing the backslashes from the authheader

[PangMo5]

Try removing the backslashes from the authheader

I checked the authHeader, but there was no backslash.

MediaBrowser Client="SwiftFin", Device="PangMo5’s iPad", DeviceId="ED8E8ABB-B796-41BC-AFB7-1A2895C0370A", Version="1.0.0", Token="xxxxxxxxxxxxxxxxxxxxxxxx"

The curious thing is that it works fine in the simulator.

[acvigue]

When it gets printed in the console - there were backslashes. Let me finish working on this part and i’ll see

…

Sent from my iPhone

On May 27, 2021, at 10:59 AM, PangMo5 ***@***.***> wrote:  Try removing the backslashes from the authheader I checked the authHeader, but there was no backslash. MediaBrowser Client="SwiftFin", Device="PangMo5’s iPad", DeviceId="ED8E8ABB-B796-41BC-AFB7-1A2895C0370A", Version="1.0.0", Token="xxxxxxxxxxxxxxxxxxxxxxxx" The curious thing is that it works fine in the simulator. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.

[PangMo5]

I found the cause.
There seems to be a conflict with the name of the actual device.
If you remove the Device from the authHeader, it works normally.

[acvigue]

Try escaping the Device name - I'd rather keep it in as it allows users to see the device name in the web dashboard

[PangMo5]

Try escaping the Device name - I'd rather keep it in as it allows users to see the device name in the web dashboard

Yes it is important.
Let me find out if there is another way.

[PangMo5]

https://github.com/jellyfin/jellyfin-sdk-kotlin/blob/47551efa5228026a1e7c81bd1b14c696fd7cc70d/jellyfin-api/src/main/kotlin/org/jellyfin/sdk/api/client/KtorClient.kt#L169

I solved it by found the relevant code in the Kotlin SDK.

[acvigue]

Please resolve the merge conflict in project.pbxproj and rebase :)

[PangMo5]

Please resolve the merge conflict in project.pbxproj and rebase :)

Resolved conflic. Please merge it.

[PangMo5]

Please don't merge this yet.
Let me solve the Know issues.

[acvigue]

Okay, take your time :)

[PangMo5]

@acvigue fixed all issues, Please merge it :D

[acvigue]

Hey! Thanks. I'll look at this when I get off work tmrw.

[acvigue]

what exactly is LazyView.swift?

[PangMo5]

what exactly is LazyView.swift?

Like other Views in SwiftUI, NavigationLink is not lazy.
Therefore, Life cycle problems can occur and LazyView helps this.

[acvigue]

i see - what problems occur without lazyview. also if the extension is only used in one file, it shouldnt be abstracted away for the sole purpose of abstraction IMO

[PangMo5]

i see - what problems occur without lazyview. also if the extension is only used in one file, it shouldnt be abstracted away for the sole purpose of abstraction IMO

It doesn't matter if you don't abstract it in a personal project.
But I think it's different in massive projects.
Because extensions of the same function can continue to occur.
I think this method can be used many times later.

[acvigue]

lgtm!
only comment -buttons are way too close together on library view

[acvigue]

will merge once buttons are respaced :)

[PangMo5]

will merge once buttons are respaced :)

What does the spacing of the buttons mean? Are you talking about the spacing of the navigation buttons?

[PangMo5]

Conflict occurred in LibraryView during Merge.
It was too big conflic, so I chose all of them as my code.
Please check if there is a missing code.

[acvigue]

lgtm