Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to utilize image API #225

Merged
merged 3 commits into from
Nov 13, 2021
Merged

Change to utilize image API #225

merged 3 commits into from
Nov 13, 2021

Conversation

PangMo5
Copy link
Member

@PangMo5 PangMo5 commented Nov 12, 2021 •
edited

  • Change to utilize image API

@PangMo5
Change to utilize image API
5c24550 
Change the url image format to webp
@PangMo5 PangMo5 added the enhancement New feature or request label Nov 12, 2021
@PangMo5 PangMo5 self-assigned this Nov 12, 2021
LePips
LePips requested changes Nov 12, 2021
View reviewed changes
JellyfinPlayer.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
@PangMo5 PangMo5 requested a review from LePips November 12, 2021 14:18
@PangMo5
Copy link
Member Author

PangMo5 commented Nov 12, 2021

Oh, it seems that webP support is not available on tvOS.
I'll go back to jpg.

@sonarcloud
Copy link

sonarcloud bot commented Nov 12, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
12.3% 12.3% Duplication

@acvigue
Copy link
Member

acvigue commented Nov 13, 2021

Sorry - would've reviewed this earlier. I was at a college tour.

@acvigue acvigue merged commit 2a4a30b into jellyfin:main Nov 13, 2021
@PangMo5 PangMo5 deleted the imageAPI branch November 13, 2021 22:16
@PangMo5
Copy link
Member Author

PangMo5 commented Nov 13, 2021

np 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LePips LePips LePips approved these changes

@acvigue acvigue acvigue approved these changes

Assignees

@PangMo5 PangMo5

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PangMo5 @acvigue @LePips