iOS: hide home indicator on devices without a home button #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the latest version of the tweak already in Swiftfin (sourced in comments). Swizzles to make iOS query the child view
|
Kudos, SonarCloud Quality Gate passed!
|
LePips
approved these changes
Dec 28, 2021
|
There is some cleanup that can be done with this now but I can get to that. |
This was referenced Dec 31, 2021
|
Am I supposed to do anything for the workaround? Because the Home bar never hides itself for me in the version on AppStore right now. |
|
This fix pre-dates the recent big refactor. I haven't had the time to take another look at this |
|
The big refactor fixes it and just needs to be released after some things have been polished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swiftfin already contains a workaround to hide the home indicator, but this doesn't work any more.
The author of the workaround updated their gist with a workaround for SwiftUI lifecycle. I've applied these changes to Swiftfin.
Some things to note:
The new workaround uses swizzling to point iOS to the right PreferenceUIHostController. Swizzling is generally considered a last resort and likely to break in future iOS versions.
The gist uses a separate pod to do swizzling. Swiftfin seems light on dependencies, we could look into implementing the swizzling within the repo. Personally I wouldn't, since this swizzling should be replaced by a better solution when available. The pod dependency can help as a reminder to remove it.
I'm new to SwiftUI, so I hope I didn't commit any basic mistakes. I added the new wrapper view in VideoPlayer.swift and had to update the edge insets to ignore the safe area.
Anyway, let me know what you think.