-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tvOS Cinematic Home Screen View and Recently Added #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted to draft as I want to adjust some things I thought about first |
acvigue
approved these changes
Jan 10, 2022
merging 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of #274, merge it first
Adds a big cinematic view to the home screen on tvOS. Resume items will be shown if there are any, otherwise Recently Added items will be shown. There isn't a good way to combine both Resume and Next Up items such that they are ordered by "last interacted with", however I have work in there such that Next Up items can be put in there as well for the future.
Adds the Recently Added to iOS as well.
ContinueWatchingView
is still there even though it doesn't do anything because I have thoughts of making the home screen customizable in the future when I tackle a home screen redesign.