Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @Published used for input(keyboard) binding (side effect) #78

Merged
merged 2 commits into from
Jun 19, 2021

Conversation

PangMo5
Copy link
Member

@PangMo5 PangMo5 commented Jun 19, 2021

Previously, input binding was received directly from ViewModel for TextField, etc.
As a result, there was a problem where the keyboard cursor was initialized because the view was reloaded when received input.
and couldn't use the iOS remote keyboard in tvOS.

So I changed the related @published to a combination of @State and CurrentValueSubject.

@PangMo5 PangMo5 requested a review from acvigue as a code owner June 19, 2021 09:18
JellyfinPlayer tvOS/ConnectToServerView.swift Outdated Show resolved Hide resolved
JellyfinPlayer/ConnectToServerView.swift Outdated Show resolved Hide resolved
JellyfinPlayer/LibrarySearchView.swift Outdated Show resolved Hide resolved
@PangMo5 PangMo5 requested a review from acvigue June 19, 2021 14:45
@acvigue
Copy link
Member

acvigue commented Jun 19, 2021

lgtm

@acvigue acvigue merged commit 31ba7a0 into jellyfin:main Jun 19, 2021
@PangMo5 PangMo5 deleted the PangMo5/binding-side-effect branch July 23, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants