Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tvOS Video Player #82

Merged
merged 13 commits into from
Jun 24, 2021
Merged

tvOS Video Player #82

merged 13 commits into from
Jun 24, 2021

Conversation

stevebyatt10
Copy link
Contributor

@stevebyatt10 stevebyatt10 commented Jun 21, 2021 •
edited

This PR aims to add a VLC video player for tvOS.

To do:

  • Now playing center
  • Playback reports to Jellyfin server
  • Info panel (video info, subtitles and language selection)
  • Pass Jellyfin media item to SwiftUI view representable

Current Issues:

  • On real tvOS devices, when VLC video starts playing the gestures stop being recognized

Images:
Simulator Screen Shot - Apple TV 4K (at 1080p) (2nd generation) - 2021-06-23 at 13 37 48

@stevebyatt10 stevebyatt10 mentioned this pull request Jun 21, 2021
Closed
5 tasks
@acvigue
Copy link
Member

acvigue commented Jun 22, 2021

sorry about the pods thing :(
good to see you got it resolved!

@stevebyatt10 stevebyatt10 marked this pull request as ready for review June 22, 2021 07:08
@stevebyatt10
Copy link
Contributor Author

Unfortunately i can't test the now playing center in the simulator, and i can't debug the touch gesture issue on real devices as i can't build to real devices.

@acvigue
Copy link
Member

acvigue commented Jun 22, 2021

Unfortunately i can't test the now playing center in the simulator, and i can't debug the touch gesture issue on real devices as i can't build to real devices.

sent you a development cert and provisioning profile in Matrix. Hope it works!

@acvigue
Copy link
Member

acvigue commented Jun 23, 2021

is this branch ready?

@stevebyatt10
Copy link
Contributor Author

is this branch ready?

Apart from the issue on actual devices and seeing if the now playing centre is working, everything is okay in the simulator

@acvigue acvigue merged commit 3f1b9f1 into jellyfin:main Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PangMo5 PangMo5 PangMo5 left review comments

@dkanada dkanada dkanada left review comments

@acvigue acvigue acvigue requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stevebyatt10 @acvigue @PangMo5 @dkanada