Issue 30 - /3/person/latest and /3/person/popular #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created GetPersonList methods in TMDbClientPeople as similar to GetMovieList in TMDbClientMovie to support the person/popular api get request. Added necessary classes for the deserialization of the REST response; as well as an enumeration describing the PersonListType (for now, we only have 'Popular') - this resembles MovieListType.
Added a test case for GetPersonList method in TMDbClientPeople. Test case mirrors TestMovieList, but for People.
TMDb API does not publicize an optional language parameter for person/popular
Created GetPersonItem method in TMDbClientPeople to support the person/latest api get request. Created an enumeration describing the PersonItemType (for now, we only have 'Latest') - this resembles MovieListType / PersonListType. Note that this is a different method to GetPersonList because /latest only returns a single person, rather than a list of people (thus it is not wrapped in a SearchContainer). Added TestPersonItem to test this new method.
|
Seems good to me. Just needs a minor Namespace update on your two Objects/Enums. |
Corrected Namespaces on PersonItemType and PersonListType. Also renamed TestPersonList to TestPersonsList; and TestPersonItem to TestPersonsItem to match current convention
|
Absolutely... fixed those namespaces on PersonItemType and PersonListType. |
LordMike
added a commit
that referenced
this pull request
Sep 16, 2014
Issue 30 - /3/person/latest and /3/person/popular
|
Absolutely! Will see what else I can contribute 👍 |
|
Great job, was on vacation so sorry for the very late reply :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented wrappers for the API methods
/3/person/latest
/3/person/popular
as requested in issue #30
please review commits & changes on branch issue-30 and merge with master.
-Wes Alcock