Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 29 - Added Reviews Namespace #53

Merged
merged 2 commits into from
Sep 18, 2014
Merged

Conversation

bluebery
Copy link
Contributor

Added Reviews namespace and support for /3/review/{id}
Also added 'Reviews' MovieMethod type and client method(s) GetMovieReviews in TMDbClientMovies.cs

Created / Modified test methods for each component.

Please review & merge 馃憤

Including necessary Review object and a GetMovieReviews test method.
Including both /3/movie/{id}/reviews and the &append_to_response
approaches.

Not including /3/review/{id} yet
Including a test class - ClientReviewTests.cs.

Changed Review.cs to use proper MediaType enum.
Flipped IsNull checks to IsNotNull in three different Tv Test methods
since TMDb is now giving a non-null value.
LordMike added a commit that referenced this pull request Sep 18, 2014
Issue 29 - Added Reviews Namespace
Seems good.
@LordMike LordMike merged commit 23c2f75 into jellyfin:master Sep 18, 2014
@LordMike LordMike mentioned this pull request Sep 18, 2014
2 tasks
@bluebery bluebery deleted the issue-29 branch September 18, 2014 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants