Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to exit from fullscreen with the back button in ExoPlayer #1173

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

timm0e
Copy link
Contributor

@timm0e timm0e commented Aug 24, 2023

When using ExoPlayer, this allows users to exit the full-screen mode by pressing the back button, similar to e.g. the YouTube app.

@jellyfin-bot jellyfin-bot added this to the v2.6.0 milestone Aug 24, 2023
@Maxr1998 Maxr1998 self-requested a review August 24, 2023 22:39
@Maxr1998 Maxr1998 added enhancement New feature or request exoplayer Related to the ExoPlayer integration labels Aug 24, 2023
Copy link
Member

@Maxr1998 Maxr1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable. Thanks for the contribution!

@Maxr1998 Maxr1998 merged commit 1198654 into jellyfin:master Aug 24, 2023
7 checks passed
@elnoelsi
Copy link

Im not sure if this was the change but now when i use back gesture it goes to portrait mode from landscape mode instead of actually leaving fullscreen @Maxr1998

@Maxr1998
Copy link
Member

Yes, that's how it's supposed to work. You switch from landscape to portrait and leave fullscreen at the same time. It's the same that happens when pressing the fullscreen switcher in the UI.
While in landscape, the player will always be in fullscreen to not overlap the video, especially since we don't show any other content there.
In portrait mode, the player won't enable fullscreen, because the video size is limited by the horizontal width there and not the system bars. In the future, we might show more data best to the video, like next up or cast, to fill the empty area with useful information.
The only exception is portrait video, where you can enter and exit fullscreen while staying in potrait mode.

@elnoelsi
Copy link

elnoelsi commented Sep 13, 2023

i dont mean to be offensive, but this is pretty useless behavior forcing you to take 2 actions if you want to close the player, no matter what. its actually horrible cause after leaving landscape you have to move your finger to a different edge to be able to back gesture.

i dont see how it could ever be useful, if i want to close the player i want to do just that. if i want extra options/info i will tap the screen. its pretty standard behavior on every app and player that ive used.

at least give an option to disable it or have it disabled when "start landscape mode" is enabled.

i dont think i can emphasize enough how much of a pain it is to have to gesture back twice every time i need to close the player, it doesnt even pause it. if i wanted to go to portrait mode i would press "exit full screen" icon that is there for a reason.

@mdinger
Copy link

mdinger commented Dec 14, 2023

Is there an option to disable this? Can one be added?

I expect the bottom back button to do the same thing as the back button at the top but it doesn't.

@elnoelsi
Copy link

There is no option thats the most annoying part of all, i genuinely think you have to be masochist to enjoy this feature in any way

@nielsvanvelzen
Copy link
Member

Please open an issue so we can discuss this change. If there is a high demand for a revert/preference we may consider it.

@mdinger
Copy link

mdinger commented Dec 15, 2023

@nielsvanvelzen as suggested, please see #1256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request exoplayer Related to the ExoPlayer integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants