Add support for external player choice inside client settings #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosOlivo
force-pushed
the
external-player-choice
branch
2 times, most recently
from
7532fee
to
6f26e4d
Compare
CarlosOlivo
force-pushed
the
external-player-choice
branch
2 times, most recently
from
3d73217
to
e6685e5
Compare
|
Since we're targeting SDK 30 we need to add the apps we query to the manifest: https://developer.android.com/about/versions/11/privacy/package-visibility |
CarlosOlivo
force-pushed
the
external-player-choice
branch
from
e6685e5
to
407cec9
Compare
|
Ok, new changes:
Note: New warning in Android Studio 4.1.
|
|
Android 10+ makes use of the new Storage API IIRC, there still is a way to get the old behavior though (but for how long 🤔) |
You can safely ignore it, we only use |
nielsvanvelzen
requested changes
Oct 15, 2020
app/src/main/java/org/jellyfin/mobile/settings/SettingsFragment.kt
Outdated
Show resolved
Hide resolved
CarlosOlivo
force-pushed
the
external-player-choice
branch
from
407cec9
to
64c2351
Compare
Maxr1998
requested changes
Oct 15, 2020
app/src/main/java/org/jellyfin/mobile/settings/ExternalPlayerType.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/mobile/settings/SettingsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/mobile/settings/ExternalPlayerType.java
Outdated
Show resolved
Hide resolved
CarlosOlivo
force-pushed
the
external-player-choice
branch
from
64c2351
to
1a379e9
Compare
Co-authored-by: Niels van Velzen <git@ndat.nl> Co-authored-by: Max Rumpf <max.rumpf1998@gmail.com>
CarlosOlivo
force-pushed
the
external-player-choice
branch
from
1a379e9
to
bac9f01
Compare
|
Thanks for the changes, I'll give it another thorough review tomorrow 👍 |
nielsvanvelzen
approved these changes
Oct 16, 2020
Maxr1998
requested changes
Oct 16, 2020
Maxr1998
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System choice by default.
Useful to force playback on a specific player without depending on android settings.
For now it only shows a list of the players that support playback tracking as long as they are installed and enabled.